https://www.getdaft.io logo
Join Slack
Powered by
targeting release cut today -- any blockers? :thre...
# daft-dev
c
targeting release cut today -- any blockers? 🧵
my pr for docs is ready for review if anyone wants to take a look https://github.com/Eventual-Inc/Daft/pull/4330
r
d
Yeah let's push back the release until we get the data source and sink PRs in
c
sounds good, whats the timeline?
r
Today
c
amazing! can u review my pr oncall 🙇 it's a bunch of css and adding algolia for search
👍 1
DONT CUT RELEASE YET. READTHEDOCS BUILD FAILED readthedocs 
latest
build 2 hrs ago failed, not sure the exact cause but coincidentally this PR was also merged 2 hrs ago 🤔 jkjk i dont think its because of requirements-dev, so my guess is the redirects in 
mkdocs.yml
is causing timeout on readthedocs? will test and update
r
I think the reqs-docs is better for readthedocs because it doesn’t have to pull in so many deps
But also do you know if building the site requires building daft, or can the docs be built without build-release?
I’ll double check the deps from my previous PR, and add the read_sql API doc
c
idk if it was read_sql too but definitely daft.sql and glob_path (i dmed u)
👍 1
i commented some stuff out and ran a build but had to leave before it finished if u wanna check on readthedocs
but ya the reqs step took 7x longer with dev vs docs so maybe we need to bring reqs-docs back
r
I'll do that to get us unblocked then
d
Oh btw don't cut yet, gonna address some comments then merge the sink too
I can cut once done
c
yeah i need to make sure readthedoc builds before we cut, ill ping u or u ping me when ready
r
@ChanChan Mao can you kick off a readthedocs and double check?
readthedocs builds are taking >20mins - I tried removing redirects and a requirements-doc, but still taking a long time. They used to be ~10 mins, but the last successful one was 23 mins.
c
weird.. but builds at least?
r
timing out still
d
fwiw, data sink pr merged
🙌 2
i think it should be fine to cut tomorrow morning instead. I can help take a look in my AM
c
i want to fix the readthedocs build before we cut release because 
latest
is still failing 😭 conner & i are trying to figure it out but feel free to take a stab
r
Working on this branch. https://github.com/Eventual-Inc/Daft/pull/4350 > It appears our builds were taking ~10 mins (+/- 5) but then jumped to 23 mins after this change. Then builds starting timing out and failing after this change. > > I've kicked off a readthedocs build for a version before both changes, which last time took about 12 mins. https://app.readthedocs.org/projects/getdaft-docs/builds/28175216/ I'm having a hard time understanding how adding two APIs to expressions.md would double the readthedocs build time.
c
yeah it shouldnt i dont think. any chance readthedocs release impacted this? https://docs.readthedocs.com/platform/stable/changelog.html
r
Trying to correlate now .. the successful build from last week that was 12 mins is still not done and it's been 20 mins 😕
😭 1
wild idea, but thinking this regex filter I added could be redos-ing the build — it's the only thread I have to pull at the moment
## Timeline * May 12, 2:25 pm — build for #f4da379e — success 11m 17s * May 13, 11:25 am — readthedocs.org 13.1.1 release * May 13, 4:20 pm — build for #fa946cfb — failure timeout 30m> * May 14, 11:07 am — build for #f4da379e — success 10m 52s That latest successful build based on my rollback makes me think readthedocs is fine. Notice too how this is all without the requirements-doc. My hunch is the regex and perhaps a readthedocs bug processing them since it works fine locally?
c
oh nice! what did u change?
r
I tried building before the commit and it did fine. So now I'm adding everything back and testing if my regex was causing build problems
🙌 2
I removed doc changes from https://github.com/Eventual-Inc/Daft/pull/4278 and still facing timeouts
c
dang
r
I've removed doc changes from both of those PRs and still failing .. it builds in 9s locally but >30mins on readthedocs
c
how did u get it to build here?
* May 14, 11:07 am — build for #f4da379e — success 10m 52s
r
• Trying with the visitor commit BUT removed changes to docs. https://app.readthedocs.org/projects/getdaft-docs/builds/28176466/ (success)
Worklog: https://github.com/Eventual-Inc/Daft/pull/4350
I'm trying to rollback all doc changes and see if latest can even build
c
ur doing gods work 🙇
r
Ok, I made some improvements and got a <https://app.readthedocs.org/projects/getdaft-docs/builds/28177633/%7Csuccessful build down to <8 mins>. • Removed I/O documents (sad) • Removed ExpressionVisitor. • Added back requirements-doc.txt only for RTD • Added back "DataFrame Creation" • Removed RTD htmlzip Slightly frustrated to walk progress back, but could not figure out why the I/O docs were taking forever to build (<10s locally yet >30mins on RTD). https://www.getdaft.io/projects/docs/en/rchowell-doc-fix/
c
thank u conner! approved ur PR https://github.com/Eventual-Inc/Daft/pull/4350, i can work on api docs for io after release cut
r
Ok cutting the release now
🙌 3
3 Views
Open in Slack
PreviousNext
Powered by