Btw, the output of `cargo clippy` outputs a whole ...
# daft-dev
r
Btw, the output of
cargo clippy
outputs a whole bunch of warnings. Let's try to clean that up as well. I'll create a separate PR to address the fixes. Might be another auto-generated diff that we'll need to take a look at. We should also consider adding
cargo fix --all
to our pre-commit hooks and GitHub workflows.
👍 1
j
That shouldn’t be the case I think Are you looking at the build without
python
feature flag?
s
Yeah we run cargo clippy with all feature flags on in CI. If we have feature flags, then clippy complains due to dead code which makes sense
r
I'll try re-running the command that I ran before that generated those warnings, although I think you're right in that I wasn't running with the
python
feature-flag. In those cases, we may want to conditionally compile those imports. Something like
#[cfg(feature = "python")] use some_mod_for_python;
.