Hey all, the rustfmt is ready to fully merge. Coul...
# daft-dev
r
Hey all, the rustfmt is ready to fully merge. Could I please get some eyes on this? Thanks! https://github.com/Eventual-Inc/Daft/pull/2807
@Sammy Sidhu, I know that you had a couple of comments on this. I believe I should have addressed them. If not, just let me know.
The build was failing yesterday because the
cargo check
command was modifying
Cargo.lock
, for which I forgot to add the diffs into version-control. After I `git add`ed the diffs, the workflow succeeded.
s
Hey not sure if im missing something but
src/arrow2
still is being modified in the PR
r
Oh that's strange. I may not have rebased my changes properly. My fault. Will fix and repush in a bit.
Apologies for the weird rebasing issue. I was reordering commits locally and must have added the
src/arrow2
by accident. Anyhoo, I have the changes up here. Made sure to check that
src/arrow2
is not being formatted at all. @Sammy Sidhu @jay @Kevin Wang
c
@Raunak Bhagat, I just added 2 small comments!