A concern I have about this is that what could end up happening is that we merge in successive PRs and the tests get cancelled, so any errors may show up late

A concern I have about this is that what could end up happening is that we merge in successive PRs and the tests get cancelled, so any errors may show up late

I think we can also change this so that it only cancels on new pushes on PRs, instead of all github refs

concurrency:
  group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
  cancel-in-progress: true

?

(successive commits to main)

Ah my b,

main

is considered a

github.ref

, so yeah it should be removed from the PR. Done

https://docs.github.com/en/actions/administering-github-actions/usage-limits-billing-and-administration Here are the limits btw. MacOS is especially concerning

some other things that would be nice: tags for force merge permissions, better test discoverability (a docs change shouldn't kick off the whole PR test suite)

other post merge tests: ASAN and TSAN would be nice

but also feels like it's possible to isolate it via test discovery