I've noticed recently our CI unit tests are slight...
# daft-dev
r
I've noticed recently our CI unit tests are slightly different than
make test
(CI is scoped to tests/ dir) and it's cause some discrepancies. Here's a fix for fresh repo
make test
https://github.com/Eventual-Inc/Daft/pull/4365 @Desmond Cheong
Alternative options presented description. Kevin just fixed something too related to this.
d
left some comments. I don't know if we can install torch by default on our current CI machines
r
Ok. Do people not use
make test
😅
d
I don't :x I agree we should fix it. Maybe we can modify make test so that the required dependency is only installed in a integration test environment
so for regular unit tests in CI we can set an env variable that skips the installation
r
I'll just update
make test
to run on the
tests/
dir so that our local unit testing is at parity with the GH action.
@Desmond Cheong bump the PR
d
Sounds good, approved