First ordinals refactor PR ready for review! Decid...
# daft-dev
k
First ordinals refactor PR ready for review! Decided to take on modifying the schema struct first. @Cory Grinstead @R. C. Howell https://github.com/Eventual-Inc/Daft/pull/4204
r
Heroic effort, the internalization looks good and we have some opportunities to improve the abstractions/helpers. No blocking comments, only thing to consider at the moment is an error variant for cause "ambiguous" rather than using "not found"
k
Ah yeah that would make sense. And yeah, still got a few bugs to squash haha
j
Heroic effort
😄 😄 😄
k
Oh btw @R. C. Howell @Cory Grinstead is this good to merge?
r
Yes all good on my end 🚢
k
done