Tiny PR to add `bun` as a dependency for all `--re...
# daft-dev
c
Tiny PR to add
bun
as a dependency for all
--release
ci workflows https://github.com/Eventual-Inc/Daft/pull/3915
Bump on this PR. Anyone should be able to review it, it just adds a few lines to our actions. We'll need to get this in before next release!
j
Stamped!
k
@Cory Grinstead this won't work for build-wheel.yml (which is used in our release process) because it builds the package in a docker container, which will not have bun installed
is there a way to build the part required for bun before running maturin? Maybe just have build.rs verify that the js assets have been built
s
Theres a way to invoke a script in the the maturin action before the build happens in the docker container: https://github.com/Eventual-Inc/Daft/blob/2b765a759061ec72a0eba971ec6da3a2920e2cb1/.github/workflows/build-wheel.yml#L90
c
is there a way to build the part required for bun before running maturin? Maybe just have build.rs verify that the js assets have been built (edited)
I'm planning on adding to our CI for PR's to make sure the
dashboard/frontend
compiles. Maybe as a test harness.
k
@Cory Grinstead fix using the before-script-linux param sammy mentioned: https://github.com/Eventual-Inc/Daft/pull/3932
@Sammy Sidhu tagged you as well. Hoping to merge this in soon because it is blocking release!