running through the tpc-ds queries and found an in...
# daft-dev
c
running through the tpc-ds queries and found an interesting blocker. many the queries will do constant exprs such as
Copy code
date_dim.d_year IN (1999, 1999+1, 1999+2)
but our
expr.is_in
can't handle that as it only works on a single Expr (usually of
Series
). opened up an issue with more info, and a potential solution.
👍 1
j
yeah seems like expression simplification is a core requirement here?
I wonder if we could naively rely on SQL-level functionality to do it for us (without having to implement full expression simplification logic in our code). Technically in Python, Python handles it for us 😛
Copy code
e.is_in([1999, 1999+1, 1999+2])
🤔 1