Hey <@U07AK4V9L0K> and <@U07GN89301J>, could I get...
# daft-dev
c
Hey @Desmond Cheong and @Raunak Bhagat, could I get a review from yall on a PR to include the file path as a column from reads pls. https://github.com/Eventual-Inc/Daft/pull/2953, the issues been open for 2 weeks now and don't wanna keep the issue opener waiting too long 🥲
‼️ 3
d
Will look right after this meeting
c
actually i realised i need to do some tests with pushdowns, will ping once done
👍 1
ok, ready now!
d
🫡
left two comments, but otherwise LGTM
Since our PRs cross-pollinated, @Colin Ho could you help review the PR for hive-partitioned reads? https://github.com/Eventual-Inc/Daft/pull/3029
c
ofc!
k
@Desmond Cheong would you still like me to review it as well?
d
@Kevin Wang I think just the part where we use the partition spec for the glob scan operator. Need your opinion on whether doing that makes sense to you (although I guess from our earlier discussion it sounds reasonable)
👍 1