can someone clarify what return type here should b...
# daft-dev
@Raunak Bhagat
r
Hmm let me take a look. One second.
What is
list_value_counts
doing at a high level?
a
look at the issue I linked
goal is to make this
image.png
return type looks to be
List [Struct [value: Utf8, count: Int32]]
so... series?
List is series right?
r
So looks like each element is a JSON list. On first impressions, seems like
DaftResult<ListArray>
seems like the proper answer. @Kevin Wang does that sound right?
a
I know @Sammy Sidhu mentioned a Map type
or something of that sort
🤷
k
It looks like it should be a list of structs, so the return type should be
DaftResult<ListArray>
. You can also return a
DaftResult<Series>
. The list array gets converted into a series eventually anyway
🙌 1
s
@jay and I spoke about this and we think it makes sense to return a
MapArray
where the Key is the type that is inside the
ListArray
and the Value is the
Count
.
👍 1
a
@Kevin Wang @Sammy Sidhu @Raunak Bhagat any of you free
r
Finishing up some docs right now, but maybe in an hr?