<https://github.com/Eventual-Inc/Daft/blob/main/.p...
# daft-dev
a
https://github.com/Eventual-Inc/Daft/blob/main/.pre-commit-config.yaml#L78-L103 is there a particular reason clippy and check are run? @Sammy Sidhu
.
s
We want to ensure that the code compiles for both the python feature on and off. Where-as we only care about cargo clippy not throwing any warnings in the case of all features on
a
added a few clippy lints for fun
most seem to be us not using
Self
just from
Copy code
complexity = { level = "deny", priority = -1 }
nursery = { level = "deny", priority = -1 }
perf = { level = "deny", priority = -1 }
style = { level = "deny", priority = -1 }
suspicious = { level = "deny", priority = -1 }
too_long_first_doc_paragraph = "allow"
derive_partial_eq_without_eq = "allow"
enum_variant_names = "allow"
module_name_repetitions = "allow"
option_if_let_else = "allow"
unsafe_block_in_unsafe_fn = "allow" # some pyo3 macros trigger this
and redundant clones and stuff
but my guess is compiler (hopefully) takes those out
s
@Andrew Gazelka That seems like a good idea to implement. Want to make some PRs that incrementally turn on these rules?
a
ok yea I will look into this. Some should be able to be automatically fixed as well so will look into that
😭