PR for more sql functions. this time `image_decode...
# daft-dev
c
PR for more sql functions. this time
image_decode
https://github.com/Eventual-Inc/Daft/pull/2757
πŸ™Œ 1
πŸ‘€ 1
@jay @Kevin Wang could one of you take a look at this PR when you get a moment.
here's a followup PR to add
image_encode
https://github.com/Eventual-Inc/Daft/pull/2764
j
Reviewing image_decode now
c
just added
image_resize
to the 2nd PR.
j
Man I almost wish we could plug chatgpt in to migrate these for us
πŸ˜›
Ok reviewed the second as well, looks like it’s just much like the first one Same comments as the first PR: I think we can introduce some helper structs/functions to reduce the boilerplate code required in
fn from_sql
β€” we should be able to parse the inputs and then present them nicely to the implementor as maybe a HashMap?
c
@jay could you take another look, i got the rest of the image functions added now!
πŸ™Œ 1
j
I’m going to be back-to-back booked today 😬 might be a while till I get to a review!
k
I’ll take a look when I get the chance!
πŸ™Œ 1