<https://github.com/Eventual-Inc/Daft/pull/2787> w...
# daft-devc
Chuanlei Ni
09/04/2024, 3:33 PMhttps://github.com/Eventual-Inc/Daft/pull/2787 waiting for review
🔥 1
j
jay
09/04/2024, 6:37 PMAmazing 😮 😮 😮 we’re taking a look
s
Sammy Sidhu
09/06/2024, 12:02 AMJust left a review! Main feedback is that we should rely on the async apis from HDRS.
I mocked it up in this commit here: https://github.com/Eventual-Inc/Daft/pull/2796/commits/b15cab5b306e7189d1567fc51305b7310621c3bb
Sammy Sidhu
09/06/2024, 12:03 AMAlso we should also add an integration test that runs a local HDFS server that we can test this on.
See these for reference: https://github.com/Eventual-Inc/Daft/tree/main/tests/integration/io
We spin up docker services that io tests can then run on
c
Chuanlei Ni
09/06/2024, 2:05 AMthank you. I will improve the code.
🙌 1
2 Views