could I get a review on https://github.com/Eventual-Inc/Daft/pull/2783? it uses a macro to reduce a ton of boilerplate when creating new expr functions. LMK if the macro usage makes it harder to understand what's going on, or if they feel unintuitive.

One thing I am concerned about for this change is development experience. rust-analyzer kind of just gives up on various language features when using a macro, and when you have errors in a macro invocation it usually shows up in the macro definition itself

yeah that's totally a valid concern. I would also prefer avoiding the usage of macros, but the sheer amount of boilerplate needed for each of these makes macros really compelling.