how do we run the lint command in local dev env? <...
# daft-devc
Chuanlei Ni
09/12/2024, 6:20 AMhow do we run the lint command in local dev env? @jay
d
Desmond Cheong
09/12/2024, 6:29 AMWhich linter are you thinking off? Most linting should be triggered by pre-commit hooks
s
Sammy Sidhu
09/12/2024, 6:40 AMif you run
make hooksSammy Sidhu
09/12/2024, 6:40 AMto manually run it, you can run
Copy code
pre-commit run --all-filesc
Chuanlei Ni
09/12/2024, 6:41 AMhttps://github.com/Eventual-Inc/Daft/actions/runs/10822844665/job/30027374884 I have a pr which has style error. but it does not have problem when i push the code
s
Sammy Sidhu
09/12/2024, 6:42 AMWhat happens if you run
pre-commit run --all-filesc
Chuanlei Ni
09/12/2024, 6:42 AMyes. it failed. i will fix the pr.
s
Sammy Sidhu
09/12/2024, 6:43 AMThe precommit command should also autofix the error for you for the simple stuff!
c
Chuanlei Ni
09/12/2024, 6:44 AMbut it does not do it.