still waiting on a review for <https://github.com/...
# daft-dev
c
๐Ÿ‘ 1
๐Ÿ‘€ 1
j
Dropped a review โ€” thereโ€™s some conflicts with @Sammy Sidhu โ€˜s refactors which we need to work through I think 2 main areas that I noticed: some things around the datatypes utilities (ImageMode etc) and then some more around display logic (the html repr logic)
c
@Sammy Sidhu @jay this should be ready for another review. i understand the concern about the
html_value
but unfortunately, I don't think there's a good way around it currently. We'd have to move the entire
ImageArray
out of daft-core, which isn't really possible with our current architecture.
s
Should be good to merge!
๐Ÿ™Œ 1