PR to fix Q2 for local executor <@U041QSEF2H2>: <h...
# daft-dev
c
PR to fix Q2 for local executor @Sammy Sidhu: https://github.com/Eventual-Inc/Daft/pull/2678
Screenshot of q2 passing is in github comment, but i also ran the dataframe test_joins.py locally to make sure its good
Just running`DAFT_ENABLE_NATIVE_EXECUTOR=1 pytest tests/dataframe/test_joins.py` is hella slow and will fail alot because we haven't implemented the other joins, so i manually added skip for non-inner + non-hash joins, this is the result:
s
oh lol, that's a tons of skips
c
yeah most of the tests are parametrized with:
Copy code
@pytest.mark.parametrize(
    "join_strategy",
    [None, "hash", "sort_merge", "sort_merge_aligned_boundaries", "broadcast"],
    indirect=True,
)
@pytest.mark.parametrize("join_type", ["inner", "left", "right", "outer"])
s
Yeah instead of a skip, we should have the pytest fixture generate only valid tests
reviewed!