<@U06N1KAUCUV> <@U0664J23JMP> can I get a quick re...
# daft-dev
j
@Kevin Wang @Colin Ho can I get a quick review on: https://github.com/Eventual-Inc/Daft/pull/2320
👍 1
s
Hmm, maybe we should have a flag to have to either print it or return as string?
k
Would it be useful to return it?
j
I think my ideal behavior would be that it returns a
Explain
object that has a nice repr/repr_html?
s
I believe that’s what we had before and we had it print it instead since that’s what most libraries do
Not a big fan of the Object based approach tbh
Seems easier to return it if requested and default on printing it
j
Hmm, maybe we should have a flag to have to either print it or return as string?
@Sammy Sidhu is this comment blocking? I wanted to have this in the next release so I can log the plans as we’re running the benchmarks!
s
Nah not blocking