ive been running into issues due is the usage of ...
# daft-dev
c
ive been running into issues due is the usage of unstable trait alias feature such as
trait TableChunkStream = Stream<Item = super::Result<Context<JoinHandle<DaftResult<Table>>, super::JoinSnafu, super::Error>>>;
. They make rust-analyzer pretty much completely unresponsive for me and usually just results in an
unknown
or
impl Send
type. 2 questions 1. Do y'all have special configurations on your local editor/ide to allow trait aliases to work with trait aliases 2. is there any reason we cant just use wrapped trait instead? e.g:
Copy code
trait TableChunkStream: Stream<Item = ...>> + Send + Unpin {};
impl <S> TableChunkStream for S where S: Stream<Item = ...>> + Send + Unpin {}
first image is with a trait wrapper, second is with the current trait aliases
c
Ah yes, there is a bug (or lack of support, rather) in rust-analyzer around trait aliases, which necessitated that
assert_stream_send
. • https://github.com/rust-lang/rust-analyzer/issues/2773https://github.com/rust-lang/rust-analyzer/issues/15566https://github.com/rust-lang/rust-analyzer/issues/13410 If you'd like to refactor to such a wrapped trait, I would be more than fine with that!
c
c
Approved and merged!
🙌 2